Conversation
Owner
Author
|
I'm not sure what's causing the CI failure on the Ubuntu 26.04 runner. I reproduced the environment locally using an Ubuntu 26.04 Docker container, and all tests passed successfully. For now, I'm switching the workflow back to the Ubuntu 24.04 runner so this PR can be merged. I'll investigate the 26.04 runner issue separately in a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queue_close
reg_mask/drain_target) race .SPSC
slot.total_chunksinspsc_pop_var()andspsc_try_pop_var()(read-after-release race).MPSC
mpsc_pop()(headvspublish[idx].seqreorder issue).Synchronization
uint8_t→atomic<uint8_t>), eliminating a plain-field data race.Memory Layout
alignas(CACHELINE)members already provide the required cache-line separation.reader_active_masktoPaddedAtomicU64to eliminate false-sharing risk.reader_pos[64]andconsumer_ctx[64]to padded, cacheline-safe types.PublishEntryinto a properly alignedalignas(CACHELINE)C++ structure instead of relying on manual padding.Initialization API
Added low-level
queue_init()andqueue_destroy()APIs .Simplified
Queue.__cinit__(),Queue.__init__(), andQueue.__dealloc__()by delegating initialization and cleanup toqueue_init()andqueue_destroy().