fix(agent-scan): honor provider timeout_ms in HTTP requests - #625
fix(agent-scan): honor provider timeout_ms in HTTP requests#625rwinkelman wants to merge 1 commit into
Conversation
|
Thanks @rwinkelman for fixing #613. Honoring One heads-up before merge: this PR overlaps heavily with the maintainer's in-flight PR #617, which edits the exact same Suggestion:
Otherwise the logic is sound. Once the conflict with #617 is resolved, this is good to merge. |
|
Grooming pass: timeout_ms honor for HTTP provider. Ping if anything else is needed before merge. |
|
Thanks for the grooming pass, @rwinkelman — the change is still sound. Just a reminder that the merge conflict with #617 stands: my in-flight PR #617 edits the exact same Since #617 is mine, I'd suggest one of:
Either way the logic is correct and checks are green. Want to coordinate on which one we keep? |
Fixes #613
Summary
Honor
timeout_msfrom provider config in agent-scan HTTP requests.Test plan