14_fibonacci: add negative number example to readme - #660
Conversation
mao-sz
left a comment
There was a problem hiding this comment.
Instead of this, we should just add onto the end of the README that it should return "OOPS" if passed a negative number. The example code block is only for clarifying the previous instruction about the sequence starting at 1 instead of 0. Just having text instruction for negatives is sufficient.
|
Thanks for the feedback! I've updated the README to remove the code example and only added the text instruction at the end as requested. |
mao-sz
left a comment
There was a problem hiding this comment.
Since the code block is specifically to give an example for the sentence about the Fibonacci sequence, the instruction about the negative arg should go after it at the end, not between it and its associated instruction.
|
Thanks for the feedback again! I've moved the note regarding negative numbers to the end of the README, right after the code example. |
Co-authored-by: mao-sz <122839503+mao-sz@users.noreply.github.com>
Because
The README for the Fibonacci exercise does not mention that passing a negative number should return "OOPS", even though this behavior is tested in
fibonacci.spec.js. Adding this example clarifies the exercise requirements.This PR
fibonacci(-1); // returns "OOPS"example to the README code block.Issue
N/A
Additional Information
N/A
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder