bench_collectives: default --dtype to all, loop through bf16/fp16/fp32 - #3
Open
NayanNagabhushana-28 wants to merge 1 commit into
Open
NayanNagabhushana-28 wants to merge 1 commit into
NayanNagabhushana-28 wants to merge 1 commit into
Conversation
Collaborator
|
I think its a great idea to expand the dtypes covered. PR #4 specifies dtypes that should be run per benchmark. This PR can then default to running all relevant dtypes for the benchmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bench_collectives.pydefaulted--dtypetobf16and only ran that one. Changed the default toall, now it loops throughbf16,fp16, andfp32, running the full collectives suite (AllReduce, AllGather, ReduceScatter) for each dtype. We can still run a single dtype with--dtype fp16if needed.