Skip to content

* Fixed mashing for even number of TOF bins. - #1755

Open
NikEfth wants to merge 1 commit into
masterfrom
fix_tof_mashing
Open

* Fixed mashing for even number of TOF bins.#1755
NikEfth wants to merge 1 commit into
masterfrom
fix_tof_mashing

Conversation

@NikEfth

@NikEfth NikEfth commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Changes in this pull request

This PR fixes #1751. With even number of TOF abs, naive inversion does not work. If even we need to subtract 1.
Now, both -1 and 0 become a mashed TOF bin 0 but they have inverted detectors.

Testing performed

New tests introduced to explicitly check the transformation with even and odd TOF bins, with and without mashing.

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality (if applicable)
  • The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

Contribution Notes

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in STIR (the Work) under the terms and conditions of the Apache-2.0 License.
  • I (or my institution) have signed the STIR Contribution License Agreement (not required for small changes).

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 6 duplication

Metric Results
Complexity 0
Duplication 6

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

potential problems with even TOF bins and TOF mashing

2 participants