Add test for template 3.33 - #1606
Merged
lesserwhirls merged 1 commit intoSep 22, 2026
Merged
Conversation
lesserwhirls
approved these changes
Sep 22, 2026
Member
|
Thank you for following up with a test and sample index file! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is the missing unit test for #1590.
I was not sure what values to test for - the unusual thing for parsing 3.33 templates is that the 4 extra values (compared to 3.30) are not needed to parse values from the grib file - it should be treated as a 3.30 template. Therefore the important bit is that the parsing does not fail with an exception.
I have added a simple dimensions check to get some basic values from the index file.
PR Checklist
until ready for review