Conversation
tarikware
commented
May 23, 2026
| {"dns-verb", no_argument, 0, 'v' }, | ||
| {"blacklist", required_argument, 0, 'b' }, | ||
| {"whitelist", required_argument, 0, 't' }, | ||
| {"whitelist", required_argument, 0, 'W' }, |
Author
There was a problem hiding this comment.
Lowercase w and t already exist as argument abbreviations. Thus, I am using uppercase W.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Some websites aren't compatible with GoodbyeDPI. The users may need to whitelist such pages in order GoodbyeDPI to ignore the requests made to them.
The pull request #305 from jimraynor2470 proposed adding the whitelist option but the fork got obsolete now, has merge conflicts and some errors. This PR resolves those conflicts and fixes the errors. Commits from jimraynor2470 are left intact except the parts that conflicted.
I built the program from source and tested the feature on some webpages. Your review and further testing would be appreciated.
Thanks.