Release 0.8.2 - #59
Merged
Merged
Conversation
Times are shown in your time zone rather than UTC. Backups are stored timezone-aware in UTC deliberately - version ids must sort identically on every machine, and sync and retention depend on it - but every display rendered the stored value raw. On a machine offset from UTC the whole product was wrong by that offset, with nothing to indicate it. Five and a half hours, where it was noticed. Fixed in all four places a timestamp appears: the dashboard's game and version lists, gsg status, and gsg versions. Display only; ordering is untouched. Found and fixed by @Tudzer in #58. Present since the dashboard shipped in 0.6.0, and in every release since.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One fix, found and largely written by @Tudzer in #58.
Times are shown in your time zone rather than UTC. Backups are stored timezone-aware in UTC deliberately — version ids must sort identically on every machine, and sync and retention depend on it — but every display rendered the stored value raw:
On a machine offset from UTC the entire product was wrong by that offset, with nothing to indicate it. Five and a half hours, where it was noticed.
Fixed in all four places a timestamp appears — the dashboard's game and version lists,
gsg status, andgsg versions. Display only; ordering is untouched.Present since the dashboard shipped in 0.6.0, and in every release since. Neither the test suite nor CI nor I noticed.
Changes here
0.8.1→0.8.2inpyproject.tomland__init__.py, plus the changelog. The fix merged as #58.Verified:
gsg --versionreports 0.8.2, 325 tests pass, ruff and mypy clean,check_deps.pyconfirms all 13 runtime dependencies declared.