Remove pipenv and use pyproject.toml - #12
Open
ruaultadrien wants to merge 19 commits into
Open
Conversation
ruaultadrien
marked this pull request as ready for review
June 8, 2023 16:23
added 8 commits
June 8, 2023 18:24
Gramet
reviewed
Jun 12, 2023
Gramet
reviewed
Jun 12, 2023
Gramet
reviewed
Jun 14, 2023
Comment on lines
+30
to
+52
| echo '[tool.black] | ||
| line-length = 120 | ||
|
|
||
| [tool.isort] | ||
| profile = "black" | ||
| line_length = 120 | ||
|
|
||
| [tool.pylint.master] | ||
| load-plugins = "pylint.extensions.docparams, pylint.extensions.docstyle" | ||
|
|
||
| [tool.pylint.messages_control] | ||
| disable = """fixme, too-few-public-methods,""" | ||
|
|
||
| [tool.pylint.basic] | ||
| variable-rgx = "^[a-z][a-z0-9_]*$" | ||
| argument-rgx = "^[a-z][a-z0-9_]*$" | ||
|
|
||
| [tool.pylint.format] | ||
| max-line-length = "120" | ||
|
|
||
| [tool.pydocstyle] | ||
| add-ignore = "D107, D104, D103" | ||
| convention = "google"' > pyproject.toml |
There was a problem hiding this comment.
Instead of hardcoding the string, would there be a way to use the pyproject.toml of check-python-style instead? So it's kinda self-sustained as well.
D34D10CK
approved these changes
Nov 13, 2025
Contributor
Author
|
@Gramet I still can't merge, I need approval from someone with write access. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to run the
check-python-styleaction in a self contained step where a pyproject.toml file specific to the project is used.Therefore the behavior of the CI would be completely independent from the project it is run on.