Fix silently dropped WordPress core functions in since-data generator - #1411
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
This PR updates the WordPress @since dataset generator to avoid silently skipping valid core functions by expanding the scan scope to include core root PHP files and by enhancing @since parsing to recognize the @since MU (x.y.z) docblock form.
Changes:
- Add a root-level PHP file scan target alongside the existing
wp-includes/andwp-admin/recursive scans. - Update the
@sinceextraction regex to support the@since MU (3.0.0)format used by some WordPress MU–ported functions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks to Codex’s review, I noticed that Could we use an explicit allowlist of WordPress core entrypoints instead? |
Fixes #1398
Summary
tools/generate-wp-function-since-data.phpwas silently dropping valid WordPress core functionsFixes
@since MU (3.0.0)docblocks not matched — the regex required digits right after@since, so functions using the frozenMU (x.y.z)form (get_active_blog_for_user,wpmu_activate_signup,domain_exists, …) were skipped.wp-includes/andwp-admin/were scanned, missing global functions inwp-signup.php(confirm_blog_signup),wp-cron.php, andxmlrpc.php.