test(core/txpool/legacypool): drop shared config writes from parallel tests - #2517
Open
gzliudan wants to merge 1 commit into
Open
test(core/txpool/legacypool): drop shared config writes from parallel tests#2517gzliudan wants to merge 1 commit into
gzliudan wants to merge 1 commit into
Conversation
… tests TestQueueAccountLimiting and TestPendingLimiting both run with t.Parallel() and both assigned testTxPoolConfig.AccountQueue, a package-level variable that every other test reads while building its pool. That is a data race, and it can also change the limits another test is asserting against. Neither test needs the global: their pools are already constructed before the assignment, so the value only ever served as the loop bound. Use a local accountQueue instead. Also fix the mismatched want value in the pending count error message, which printed AccountQueue+5 for an equality check against AccountQueue.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gzliudan
requested review from
AnilChinchawale,
anunay-xin,
benjamin202410,
liam-lai and
wanwiset25
August 12, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
TestQueueAccountLimiting and TestPendingLimiting both run with t.Parallel() and both assigned testTxPoolConfig.AccountQueue, a package-level variable that every other test reads while building its pool. That is a data race, and it can also change the limits another test is asserting against.
Neither test needs the global: their pools are already constructed before the assignment, so the value only ever served as the loop bound. Use a local accountQueue instead. Also fix the mismatched want value in the pending count error message, which printed AccountQueue+5 for an equality check against AccountQueue.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that