Skip to content

fix: bring back the blank line between release notes sections - #341

Open
AbdulrhmanGoni wants to merge 2 commits into
absolute-version:masterfrom
AbdulrhmanGoni:fix/return-blank-line-between-release-sections
Open

fix: bring back the blank line between release notes sections#341
AbdulrhmanGoni wants to merge 2 commits into
absolute-version:masterfrom
AbdulrhmanGoni:fix/return-blank-line-between-release-sections

Conversation

@AbdulrhmanGoni

Copy link
Copy Markdown

A one-liner that fixes #311

More context: conventional-changelog/conventional-changelog#1511 (comment)

@TimothyJones acknowledged this issue in #311 (comment), but looks like he forgot about it

@TimothyJones

Copy link
Copy Markdown
Member

Thank you! Can we add a test so this doesn’t come back?

@AbdulrhmanGoni

AbdulrhmanGoni commented Sep 10, 2026

Copy link
Copy Markdown
Author

Thank you! Can we add a test so this doesn’t come back?
@TimothyJones

I see some existing unit tests in test/core.spec.js that could cover this, the tests currently expect a changelog to be joined with old changelogs without the blank line separator.

So I think we could just update those tests to expect a blank line separator between the new changelog and the old ones

Currently I see three tests like this:

verifyNewChangelogContentEquals({
writeFileSyncSpy,
expectedContent:
frontMatter + '\n' + header + '\n' + changelog101 + changelog100,
});

We can do something like this:

 verifyNewChangelogContentEquals({ 
   writeFileSyncSpy, 
   expectedContent: 
-    frontMatter + '\n' + header + '\n' + changelog101 + changelog100, 
+    frontMatter + '\n' + header + '\n' + changelog101 + '\n' + changelog100, 
 }); 

Update: I updated the three test cases like i showed above, what do you think @TimothyJones ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lint: Missing extra space at end of new section

2 participants