fix: bring back the blank line between release notes sections - #341
Open
AbdulrhmanGoni wants to merge 2 commits into
Open
Conversation
Member
|
Thank you! Can we add a test so this doesn’t come back? |
Author
I see some existing unit tests in So I think we could just update those tests to expect a blank line separator between the new changelog and the old ones Currently I see three tests like this: commit-and-tag-version/test/core.spec.js Lines 389 to 393 in 8094d6a We can do something like this: verifyNewChangelogContentEquals({
writeFileSyncSpy,
expectedContent:
- frontMatter + '\n' + header + '\n' + changelog101 + changelog100,
+ frontMatter + '\n' + header + '\n' + changelog101 + '\n' + changelog100,
}); Update: I updated the three test cases like i showed above, what do you think @TimothyJones ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A one-liner that fixes #311
More context: conventional-changelog/conventional-changelog#1511 (comment)
@TimothyJones acknowledged this issue in #311 (comment), but looks like he forgot about it