Skip to content

Prepare the plugin for its move into acyclic-labs/sdk #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramstar3000 merged 1 commit into from
Sep 19, 2026
Merged

Prepare the plugin for its move into acyclic-labs/sdk #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .cargo/config.toml
View file
Open in desktop

This file was deleted.

15 changes: 1 addition & 14 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ concurrency:
cancel-in-progress: true

env:
FUSE_T_VERSION: 1.2.7
CARGO_TERM_COLOR: always
# acyclic-fs is fetched from its own git repo (see Cargo.toml); cargo's
# built-in libgit2 fetcher can't resolve a pinned commit SHA that isn't a
Expand Down Expand Up @@ -65,7 +64,7 @@ jobs:

# Licenses, advisories, and sources per deny.toml. Keeps the published
# SBOM inside the permissive allowlist and fails on known-vulnerable or
# yanked crates. Always runs: the secrets scan applies to docs too.
# yanked crates. Always runs: the product-name guard applies to docs too.
deny:
runs-on: ubuntu-24.04
steps:
Expand All @@ -74,8 +73,6 @@ jobs:
persist-credentials: false
- name: Product name is single-sourced (product.toml)
run: bash scripts/check-product-name.sh
- name: No forbidden files or credential patterns
run: bash scripts/check-no-secrets.sh
- name: Code quality (line width, TODO format, comment blocks, duplication)
run: bash scripts/check-code-quality.sh
- uses: EmbarkStudios/cargo-deny-action@3c6349835b2b7b196a839186cb8b78e02f7b5f25 # v2.1.1
Comment on lines 65 to 78

@greptile-apps greptile-apps Bot Sep 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Credential scanning removed

This removes the repository's credential and forbidden-file scan without invoking the stated SDK replacement from this workflow. While this repository still handles pull requests and pushes to main, a committed credential or private-key file can therefore pass its CI and enter Git history.

How this was verified: The remaining deny job runs only product-name, code-quality, and cargo-deny checks after the sole credential-pattern scanner was deleted.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 65-78

Comment:
**Credential scanning removed**

This removes the repository's credential and forbidden-file scan without invoking the stated SDK replacement from this workflow. While this repository still handles pull requests and pushes to `main`, a committed credential or private-key file can therefore pass its CI and enter Git history.

**How this was verified:** The remaining deny job runs only product-name, code-quality, and cargo-deny checks after the sole credential-pattern scanner was deleted.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Expand Down Expand Up @@ -228,16 +225,6 @@ jobs:
with:
path: graphcoder-plugin

- name: Install FUSE-T (macOS)
if: runner.os == 'macOS'
run: |
set -euo pipefail
curl --fail --location --retry 5 \
"https://github.com/macos-fuse-t/fuse-t/releases/download/${FUSE_T_VERSION}/fuse-t-macos-installer-${FUSE_T_VERSION}.pkg" \
--output /tmp/fuse-t.pkg
sudo installer -pkg /tmp/fuse-t.pkg -target /
test -d /usr/local/include/fuse3

- name: Install toolchain
run: rustup toolchain install stable --profile minimal && rustup default stable

Expand Down
18 changes: 18 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,24 @@ Pre-1.0; `main` is the only supported line (see `SECURITY.md`).

### Changed

- **Prepared for the move into `acyclic-labs/sdk` as `plugin/`.** Releases
will be cut from that repository as `plugin-v<version>` tags, so
`scripts/install.sh` now targets them and reads the current version from
`plugin/LATEST` on the sdk's `main` branch (`product.toml` gained
`release_tag_prefix`, guarded by `check-product-name.sh`). The acceptance
harness, `ci-local.sh`, `docker-linux.sh` and `release-local.sh` locate the
cargo target directory and the plugin's own crates in either layout. The
crates build with edition 2024 and the sdk's stricter lint set.
- **FUSE-T is no longer required on macOS.** `acyclic-fs` mounts through its
vendored `darwinfuse` NFSv4 server, so the `fuse3` pkg-config shim, the
rpath link flag and the CI installer step are gone.
- **`acyclic-fs` is pinned to the sdk's `main` line** (the Darwin
unpaired-rename, subtree-removal and `O_EXCL` fixes landed there as sdk
PR #99); the guard forwards the new `capture_host_subtree` mount hook, and
the store asks for barrier durability only on Apple targets, since the sdk
now fails closed where `F_BARRIERFSYNC` does not exist instead of falling
back to a full flush.

- **A cold daemon no longer delays the agent's first turn.** The session-start
hook waits at most 300ms for the daemon; past that it prints a one-line
notice and returns while the first snapshot builds in the background (251s
Expand Down
1 change: 0 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ Run these locally — CI enforces all of them:

```sh
scripts/check-product-name.sh # the public name only comes from product.toml
scripts/check-no-secrets.sh # no forbidden files or credential patterns
scripts/check-code-quality.sh # line width, TODO(topic) format, comment-block length, duplication
cargo deny check # dependency licenses, advisories, bans
cargo fmt --all --check
Expand Down
Loading
Loading