CI: Emit JUnit from test runners, pin their exec bounds - #1687
Merged
Max Smythe (maxsmythe) merged 1 commit intoSep 23, 2026
Merged
Conversation
Steven Shriver (stshrive)
marked this pull request as ready for review
September 17, 2026 00:08
Steven Shriver (stshrive)
force-pushed
the
dev/emit-junit
branch
from
September 17, 2026 15:45
322ea8c to
955e743
Compare
Bowei Du (bowei)
added
kind/bug
Steven Shriver (stshrive)
force-pushed
the
dev/emit-junit
branch
from
September 18, 2026 17:22
955e743 to
01610f0
Compare
Steven Shriver (stshrive)
requested a review
from Anna Pendleton (annapendleton)
September 18, 2026 17:25
Anna Pendleton (annapendleton)
approved these changes
Sep 21, 2026
Today CI depend on process exit codes. This leads to a few issues with reporting results. For example, a green build cannot be distinguished from one where no tests ran at all; a `-run` filter that matches nothing; an e2e suite short-circuiting without `--e2e`; or a testcontainer skip: all currently exit 0. This change adds gotestsum as a pinned tool module allowing opt-in for JUnit reporting in both test runners by using `E2E_JUNIT_FILE` and `ROOT_JUNIT_FILE` respectively. When left unset, the runners exec `go test` directly and gotestsum is never built leaving local runs unchanged for now. Additionally, this change pins two execution bounds that `go test` would otherwise infer. Both remain overridable via environment variables as listed below. `-p`: system defaults didn't align with cluster capacity so pinning the value avoids over allocation. (E2E_PARALLELISM). `-timeout`: Suite defaults conflicted with some E2E test timings causing some tests that are expected to timeout at the same time to abort rather than fail as expected. Setting an 30m default avoids the conlficting timeouts producing clean failure signals. (E2E_TIMEOUT).
Steven Shriver (stshrive)
force-pushed
the
dev/emit-junit
branch
from
September 22, 2026 17:23
01610f0 to
55768d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today CI depends on process exit codes. This leads to a few issues with reporting results. For example, a green build cannot be distinguished from one where no tests ran at all; a
-runfilter that matches nothing; an e2e suite short-circuiting without--e2e; or a testcontainer skip: all currently exit 0.This change adds gotestsum as a pinned tool module allowing opt-in for JUnit reporting in both test runners by using
E2E_JUNIT_FILEandROOT_JUNIT_FILErespectively. When left unset, the runners execgo testdirectly and gotestsum is never built leaving local runs unchanged for now.Additionally, this change pins two execution bounds that
go testwould otherwise infer. Both remain overridable via environment variables as listed below.-p: system defaults didn't align with cluster capacity so pinning the value avoids over allocation. (override withE2E_PARALLELISM).-timeout: Suite defaults conflicted with some E2E test timings causing some tests that are expected to timeout at the same time to abort rather than fail as expected. Setting an 30m default avoids the conlficting timeouts producing clean failure signals (override withE2E_TIMEOUT).Fixes #1685