fix(ack-id): require DID URIs in controllerClaimSchema - #210
Open
kutluhaneth46 wants to merge 1 commit into
Open
fix(ack-id): require DID URIs in controllerClaimSchema#210kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
Validate controller credential subject id and controller as DID URIs in both Valibot and Zod so empty strings and non-DID values fail at the schema boundary. Fixes agentcommercekit#207
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controllerClaimSchemaidandcontrollerto be DID URIs in both Valibot and Zod.createControllerCredentialtypes these fields.Testing
pnpm --filter @agentcommercekit/ack-id exec vitest run src/schemas/schemas.test.ts src/controller-claim-verifier.test.tsAI usage disclosure
Assisted by Cursor. I reviewed the controller claim verifier and credential creator types, implemented the dual-schema change, and ran the focused tests myself.
Fixes #207