Skip to content

0.62.17: close second-opinion leak channels, repair master's failing checks - #61

Merged
ajschlosser merged 1 commit into
masterfrom
fix/second-opinion-leaks
Sep 20, 2026
Merged

ajschlosser merged 1 commit into
masterfrom
fix/second-opinion-leaks

Conversation

@ajschlosser

Copy link
Copy Markdown
Owner

Summary

The response filter from #60 hides a pending second opinion in any record it finds in a JSON response. This audits what it cannot see:

  • Record preview: the JSONL string is now built from the record as this reviewer may see it.
  • Editorial memory: conventions and examples skip a field awaiting this reviewer's second opinion.
  • Record extras: rejections, re-check results, blind reveals and scheduled re-checks no longer repeat the first answer.
  • Ledger CSV: held-back values are [sealed]; the decision rows keep both answers.
  • Guard test: every /api/pdf/corpus-builds route must be classified (carries records / build-level), so a new route cannot skip the question.

Also repairs master's red checks, which were not from this work:

  • locale test: missing works.library_controls (en and fr);
  • 7 frontend test files: runtimeBridge read the runtime at import time, breaking any test that mocks part of it; each export now reads it when called;
  • mypy: evidence_sufficiency_issues now accepts a sequence of mappings.

Follows #60 (merged); based on current master.

Caveats

  • Not a defence against a reviewer reading storage or another route directly; metrics report rates, not values. No queue view for second opinions; admin-only.
  • Full Playwright suite not run.

Test plan

  • pytest 377 passed; ruff, mypy, vue-tsc clean; Vitest 306 passed (all 46 files)
  • CI

🤖 Generated with Claude Code

…ling checks; cut 0.62.17 Watertight Weasel

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ajschlosser
ajschlosser merged commit 0506432 into master Sep 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant