feat: add basic academic teacher api - #128
Open
Aleks334 wants to merge 33 commits into
Open
Conversation
5 tasks
Aleks334
force-pushed
the
119-basic-lecturer-api
branch
from
August 13, 2026 20:32
ebc265d to
91af233
Compare
Aleks334
force-pushed
the
119-basic-lecturer-api
branch
from
August 14, 2026 13:45
f7be920 to
6a84e0a
Compare
Aleks334
marked this pull request as ready for review
August 14, 2026 13:50
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
IUnitOfWorkinterface in app layer to save changes within transaction instead of adding this method to each repository interface (implementation is the same for every repo, db context already implements unit of work pattern). For me using interface is better than db context directly due to easier mocking in unit tests and architectural reasons: app layer defines interface, infrastructure implements it, so dependencies point inward as should be in our architecture. It is now possible in handlers to coordinate work across different repositories in one transaction.I read that it is questionable to do that. In DDD cross-aggregate communication is usually done via domain events:
On the other hand let's keep it simple now.
I also defined new conventions:
How to test (optional)
Nearly 1000 changed lines are just generated migrations.
useful for review:
To check whether api returns some data we need to add it. I generated seeder sql script with dummy data for that.
Steps to test:
docker compose up database pgadmin). This should apply all new migrations. If you have errors drop all tables or db docker container with volume.Infrastructure/Scripts/AcademicTeacherSeeder.sql) with some dummy academic teachers data.GET /api/academic-teachers/{id}(or use other api client)Screenshots / recordings (for UI stuff)
...
Checklist
To have your PR reviewed put the link e.g.
https://github.com/akai-org/put-wiki/pull/0to theReview PRthread on put-wiki dc channel (you must be member of the AKAI discord server)