Complete refactoring, from a prime example of overengineering - #8
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR represents a complete refactoring of the project, significantly reducing lines of code from 8,748 to 1,004 while maintaining code coverage and 90% of functionality. Caching was removed as the expected CI use cases involve checking only 1-10 releases, where caching would rarely be beneficial. Additionally, the refactor introduces color output and a new command to generate color-coded SVG badges for product releases based on EOL/EOAS/MAINTAINED status.
- Massive code reduction from 8,748 to 1,004 lines while maintaining functionality
- Removal of caching system due to limited utility in CI environments
- Addition of colored output and SVG badge generation capability
Reviewed Changes
Copilot reviewed 89 out of 98 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| util.go | New utility functions for version variants, duration parsing, URL building, JSON formatting, and other core utilities |
| util_test.go | Comprehensive test coverage for all utility functions with parallel test execution |
| testdata/handle/* | Test output files showing the application's various command outputs and API responses |
| testdata/golden/* | Golden test files containing expected API response formats |
Comments suppressed due to low confidence (1)
util.go:1
- The panic recovery assumes that the recovered value
ris always an error type. If the panic contains a non-error value (like a string), this will cause a runtime panic during the type assertionr.(error).
package main
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alexaandru
force-pushed
the
even-simpler
branch
from
August 28, 2025 11:22
bd6c2e0 to
da3b620
Compare
the LOC is down from 8748 -> 1004, while maintaining same level of code coverage & retaining 90% of functionality (only caching was removed). Caching was dropped as the expected use cases are mostly in CI, checking for 1-10? releases so caching would hardly ever be useful. Also, added a bit of colors. And a command to generate a SVG badge for a product release (appropriately color coded based on EOL, EOAS or MAINTAINED).
alexaandru
force-pushed
the
even-simpler
branch
from
August 28, 2025 11:28
da3b620 to
9f42607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the LOC is down from 8748 -> 1004, while maintaining same level of code coverage & retaining 90% of functionality (only caching was removed).
Caching was dropped as the expected use cases are mostly in CI, checking for 1-10? releases so caching would hardly ever be useful.
Also, added a bit of colors. And a command to generate a SVG badge for a product release (appropriately color coded based on EOL, EOAS or MAINTAINED).