ci: require the deterministic E2E suite on pull requests - #241
Open
zpzjzj wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JHWang-1997
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILL_UP_FULL_E2EE2E Smokecheck name for repository ruleset compatibilityWhy
PR #233 added a static agent preflight that changed the invocation sequence of a stateful E2E fixture.
TestEventLogSignalDuringBaselineReturnsNonZerodetected the regression locally, but the required PR job only selectedPipeline,CLI,Contract, andNoneRuntimetest names, so the event-log test was never run. PR #237 fixed that fixture; this change closes the CI coverage gap so new deterministic E2E test families are required automatically.Live model, sandbox, Docker, and credential-backed checks remain explicit manual suites because they depend on secrets, quotas, and external services.
Verification
go test -tags e2e -timeout 1200s -count=1 -v ./e2emake verifymake testmake test-actionmake build