feat: add a forcedToolUse capability and refuse .required without it - #34
Closed
sophie-ant wants to merge 1 commit into
Closed
sophie-ant wants to merge 1 commit into
sophie-ant wants to merge 1 commit into
Conversation
Some models reject `tool_choice` of type `any` or `tool`. The bridge maps the framework's `.required` tool-calling mode to `tool_choice: any`, so on such a model every `.required` request came back as a 400. `ClaudeModel.Capabilities` gains `forcedToolUse`. When it is `false`, a `.required` request now fails before anything is sent, with the new `ClaudeError.forcedToolUseUnsupported` — a required call is a contract, so it is refused rather than silently downgraded to optional tool use, the same way a schema on a model without structured output is. Optional and `.disallowed` tool use are unaffected. Unlike the other capability bits this one defaults to `true`: every compiled-in model accepts forced tool use, existing custom `ClaudeModel(id:capabilities:)` declarations keep working unchanged, and a wrong `true` still fails loudly (the API names `tool_choice`) rather than degrading the request.
Contributor
Author
|
Closing for now; not shipping this change at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some models reject
tool_choiceof typeanyortool. The bridge maps the framework's.requiredtool-calling mode totool_choice: any, so on such a model every.requiredrequest came back as a 400.ClaudeModel.CapabilitiesgainsforcedToolUse. When it'sfalse, a.requiredrequest fails before anything is sent, with the newClaudeError.forcedToolUseUnsupported. A required call is a contract, so it's refused rather than silently downgraded to optional tool use — the same way a schema on a model without structured output is. Optional and.disallowedtool use are unaffected.true: every compiled-in model accepts forced tool use, existing customClaudeModel(id:capabilities:)declarations keep working unchanged, and a wrongtruestill fails loudly (the API namestool_choice) rather than degrading the request.This is the second half of the change whose first half landed as #29.
Test plan
RequestBuilderTests:.requiredon a model withforcedToolUse: falsethrowsforcedToolUseUnsupported, while optional and.disallowedrequests on the same model still build; the default and the compiled-in constants reporttrue.