fix(build): fix building AVX-512 runtime dispatch code with Clang/MSVC - #358
Merged
Conversation
On certain setups, for example, FullLTO, MSVC-style architecture / instruction set flags are not enough for Clang/MSVC (clang-cl). Pass more fine-grained GNU-style arch / IS flags to Clang under MSVC, which are still accepted directly and resolve such issues. Closes #326 Signed-off-by: Alexander Lobakin <alobakin@mailbox.org>
Owner
|
Hi Alexander, Thank you for this PR; let's see if other people are fine with it. Kind regards, |
Contributor
Author
|
@aous72, it's not a Clang/clang-cl issue -- with MSVC-style flags, you only have a basic IS flags like AVX-512 etc, there's no fine-grained switches. So most projects with runtime dispatch always pass GNU-style IS switches if the compiler is Clang, like I did in this PR. |
Owner
|
@solbjorn My view is that clang-cl claims to be compatible with cl.exe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On certain setups, for example, FullLTO, MSVC-style architecture / instruction set flags are not enough for Clang/MSVC (clang-cl). Pass more fine-grained GNU-style arch / IS flags to Clang under MSVC, which are still accepted directly and resolve such issues.
Closes #326