feat(c/driver/postgresql): use preinitialized type resolver - #4775
Open
lidavidm wants to merge 9 commits into
Open
feat(c/driver/postgresql): use preinitialized type resolver#4775lidavidm wants to merge 9 commits into
lidavidm wants to merge 9 commits into
Conversation
- Ship a hardcoded type resolver, eliminating queries on the first connect - [ ] Add tests that this resolves the same entries as before - [ ] Document the option - [ ] Add ability to build the table when needed Closes apache#4749.
Member
Author
|
I still need to figure out what's going on with CrateDB but otherwise this is working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a certain option is set, then we don't query the database for type information at all and instead rely on a hardcoded table generated from Postgres. Currently, we don't try to implement any sort of smart fallback.
Closes #1755.