fix(vars): render /vars as an HTML name-value table - #3413
Open
darion-yaphet wants to merge 2 commits into
Open
Conversation
Replace the plain paragraph list with a gridtable so variable names and values align in columns, and keep expandable flot charts in a dedicated detail row.
darion-yaphet
force-pushed
the
fix-vars-html-table
branch
from
July 27, 2026 05:49
4840bd9 to
cc1239c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the usability of the built-in /vars HTML page by switching from a free-flowing paragraph layout to a structured two-column table, and by placing flot chart details into dedicated expandable rows to keep name/value scanning consistent.
Changes:
- Render
/varsHTML output as agridtablewithNameandValuecolumns. - Emit each bvar as a
<tr class="variable|nonplot-variable">and move flot charts into a following<tr class="detail-row">. - Update the page JavaScript/CSS to toggle and locate the new detail-row structure while keeping plain-text output unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Cover HTML responses triggered by a User-Agent, including the grid table, variable row, and expandable detail row. Preserve plain-text output coverage. Constraint: HTML mode is selected by the User-Agent header Confidence: high Scope-risk: narrow Reversibility: clean Directive: Update both rendering-mode assertions when changing VarsService markup Tested: BuiltinServiceTest.vars Not-tested: Full suite; the default C++0x test configuration is incompatible with local GoogleTest 1.17
Contributor
|
What does it look like when a bvar row expand? Can you give a screenshot? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
The
/varsHTML page rendered each bvar as a plain<p>line (name : value), so names and values were hard to scan when lengths varied. Expandable flot chartblocks were also mixed into the same flow, which made the layout less structured.
What is changed and the side effects?
Changed:
/varsHTML output as agridtablewithName/Valuecolumns.<tr class="variable|nonplot-variable">row.<tr class="detail-row">under the corresponding variable.curl/ plain text)/varsoutput unchanged.Side effects:
/varsis changed./varsresponses are unchanged; only browser HTML layout is updated.Check List: