fix(bitbucket): paginate remote-scopes API to return all repositories…#9004
Open
bramhanandlingala wants to merge 1 commit into
Open
fix(bitbucket): paginate remote-scopes API to return all repositories…#9004bramhanandlingala wants to merge 1 commit into
bramhanandlingala wants to merge 1 commit into
Conversation
Contributor
Author
|
@klesh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Bitbucket
remote-scopesendpoint only returned the first 100 repos/workspaces —nextPageTokenwas always empty, so the UI had no way to load more.Root Cause
listBitbucketRepos/listBitbucketWorkspacesnever set thenextPagereturn value, sonextPageTokenwas always""./repositories/{workspace}call'sfieldsfilter also excludednext, so Bitbucket wouldn't have returned it anyway.Changes Made
models/repo.go— added aNextfield toWorkspaceResponseandReposResponseto capture Bitbucket'snextlink.api/remote_api.go:nextto thefieldsfilter so Bitbucket includes it in the response.nextPagewheneverresBody.Next != "", so the UI can request the following page.api/remote_api_test.go— tests for both the next-page and last-page cases.Does this close any open issues?
Closes #8999