feat: introduce BeanWrapper SPI and decouple CGLIB from fesod-sheet - #1018
Draft
bengbengbalabalabeng wants to merge 11 commits into
Draft
feat: introduce BeanWrapper SPI and decouple CGLIB from fesod-sheet#1018bengbengbalabalabeng wants to merge 11 commits into
bengbengbalabalabeng wants to merge 11 commits into
Conversation
- Remove fesod-shaded dependency - Add fesod-beans-cglib dependency as the default BeanWrapper SPI implementation - Remove BeanMapUtils APIs and migrate callers to BeanWrappers API
bengbengbalabalabeng
added
the
not now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related: #951
DRAFT FOR NOW
What's changed?
1.
fesod-commonBeanWrapperandBeanWrapperProvider.BeanWrappersfor SPI auto-discovery (ServiceLoader) and priority-based sorting (getOrder()).2.
fesod-beans(Parent POM)fesod-beans/fesod-beans-cglibsubmodule.3.
fesod-sheetfesod-shadedwithfesod-beans-cglib.BeanMapUtils.create()usages withBeanWrappers.create().BeanMapUtilsto prevent downstream compile/runtime errors caused by hard CGLIB dependencies when switchingfesod-beans-*implementations.Checklist