Skip to content

[rust] Add SnapshotId type alias - #660

Open
Hashim1999164 wants to merge 1 commit into
apache:mainfrom
Hashim1999164:rust/snapshot-id-alias
Open

[rust] Add SnapshotId type alias#660
Hashim1999164 wants to merge 1 commit into
apache:mainfrom
Hashim1999164:rust/snapshot-id-alias

Conversation

@Hashim1999164

@Hashim1999164 Hashim1999164 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

  • add a public SnapshotId alias alongside the existing table, partition, and bucket ID aliases
  • use it across snapshot metadata, admin APIs, RPC constructors, and the Python binding
  • keep protobuf and C++ FFI boundaries on their concrete wire types

This is a readability and consistency change only; SnapshotId remains an alias for i64.

Fixes #636.

Validation

  • cargo fmt --all -- --check
  • cargo test -p fluss-rs --lib --all-features (572 passed)
  • cargo check -p fluss_python
  • cargo clippy -p fluss-rs --lib --all-features (completed with two pre-existing for_kv_map warnings in accumulator.rs)

The stricter all-targets Clippy command with -D warnings stops on those same unrelated warnings.

AI assistance

AI assistance was used to identify the remaining hand-written snapshot ID types and draft the mechanical alias substitutions. I reviewed the complete diff and ran the validation above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rust] Add a SnapshotId type alias

1 participant