Skip to content

Fix check_output_custom uses applies_to - #1688

Open
jernejfrank wants to merge 1 commit into
mainfrom
fix/custom-validator-applicability
Open

Fix check_output_custom uses applies_to#1688
jernejfrank wants to merge 1 commit into
mainfrom
fix/custom-validator-applicability

Conversation

@jernejfrank

Copy link
Copy Markdown
Contributor

#1658 added docs that flagged discrepancy between check_output and check_output_custom. The latter never used the abc method applies_to to verify it can actually validate the output based on the node type.

Added this as an if conditional, so it only applies it to outputs of the same type in case there are multiple. Alternativelly, we could raise an error instead of silent behaviour but not sure how much benefit it gives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant