Fix AI-reported bugs against current main type rules - #8244
Conversation
Verified against 2.20 DatabaseTypeMapper rather than 2.19 getFieldDefinition. - apache#8216: store JDBC precision as Hop Number length; keep numericLength() as integer digits for dialect rules; PostgreSQL writes NUMERIC(length, scale) - apache#8218: timestamp parse mask reads HOP_DEFAULT_TIMESTAMP_FORMAT - apache#8219: Stream Lookup handles Timestamp default values - apache#8220/apache#8221: SQL Server DATE/TIME/DATETIME2 and NVARCHAR/VARCHAR(MAX) via type rules - apache#8222: parameter metadata uses StandardJdbcTypeMapper - apache#8223: skip JDBC getColumns() for ordinary databases - apache#8225: do not list empty unknown metadata folders - apache#8226: split catalog.schema even when supportsCatalogs() is false - apache#8227: ProgressMonitorDialog closes when the runnable returns - apache#8230: remove dead terminal menu constants Fixes apache#8216, apache#8218, apache#8219, apache#8220, apache#8221, apache#8222, apache#8223, apache#8225, apache#8226, apache#8227, apache#8230
|
Thanks for taking these on! We run 2.19 in production and have local patches for a few of them, so we are not We have patched #8220/#8221 ourselves, but anyone else on 2.19 with SQL Server will Is a 2.19 patch release planned, and could #8216 go into the 2.19 branch? |
|
Thanks for filing the issues @fskorgen. If you're not blocked my idea is that it's best for give this PR some mileage until the 2.20.0 release in October. 2.19.0 should have a compatibility flag for the DDL issues as well so not so blocking for others either I think. |
Verified against current main / 2.20 type rules, not 2.19
getFieldDefinition. That is the answer to the review notes on #8220 / #8221.Already handled by #8214 (Database perspective)
These are not in this PR. Comments are on the issues; they should close when #8214 merges:
#8217 was already closed (UNIQUEIDENTIFIER on both SQL Server dialects).
This PR
numericLength()stays integer digits for dialect rule conditions. PostgreSQL writesNUMERIC(length, scale)so it round-trips. Does not merge #8242 as-is (that invertsnumericLength()and would inflate Postgres precision).HOP_DEFAULT_TIMESTAMP_FORMATConversionNotImplementedDATE/TIME/DATETIME2via type rules; new Date fields stayDATETIMENVARCHAR/NCHARpreserved;TEXTreplaced withVARCHAR(MAX)StandardJdbcTypeMapper(NVARCHAR,NUMERIC(p,s))getColumns()pathcatalog.schemais split even whensupportsCatalogs()is falseProgressMonitorDialogdisposes when the runnable returns (Get fields no longer hangs)USE_ADVANCED_TERMINALkey removedTests
Focused modules run under
tools/with-isolated-display.sh: core, ui, mssql, mssqlnative, postgresql (+ redshift/greenplum/cockroach), mysql, oracle, streamlookup.Fixes #8216 #8218 #8219 #8220 #8221 #8222 #8223 #8225 #8226 #8227 #8230