Fix ACME RewriteRule pattern in .htaccess recipe#686
Open
deprrous wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the mod_rewrite documentation to correct an .htaccess example so ACME HTTP-01 challenge requests are properly exempted from an HTTP→HTTPS redirect in per-directory (.htaccess) context.
Changes:
- Fix the ACME exemption
RewriteRulepattern by removing the leading/, aligning it with.htaccess(per-dir) path matching behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ACME exemption example is chained from the
.htaccessHTTPS redirect recipe in this file.In per-directory context,
RewriteRulematches the path without a leading slash, so^/\.well-known/acme-challenge/does not match ordinary ACME challenge requests there. Dropping the leading slash makes the exemption line up with the.htaccesscontext described above it.