Wrap reject-list Require example in RequireAll#687
Open
deprrous wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the mod_rewrite “reject list” documentation example to use an explicit <RequireAll> container so the configuration is syntactically valid while preserving the intended access control behavior (generally allow requests, but deny specific IPs).
Changes:
- Wrap the mixed
Require all granted+Require not ip ...directives in<RequireAll>within the<Location "/" >example. - Remove a trailing blank line at the end of the XML file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reject-list example currently mixes
Require all grantedwith bareRequire not ip ...lines inside the sameLocationblock.Wrapping those directives in
RequireAllmakes the example valid and keeps the intended meaning: allow requests generally, but deny the listed addresses.