Skip to content

Wrap reject-list Require example in RequireAll#687

Open
deprrous wants to merge 1 commit into
apache:trunkfrom
deprrous:pr/httpd-reject-list-requireall
Open

Wrap reject-list Require example in RequireAll#687
deprrous wants to merge 1 commit into
apache:trunkfrom
deprrous:pr/httpd-reject-list-requireall

Conversation

@deprrous

Copy link
Copy Markdown

The reject-list example currently mixes Require all granted with bare Require not ip ... lines inside the same Location block.

Wrapping those directives in RequireAll makes the example valid and keeps the intended meaning: allow requests generally, but deny the listed addresses.

Copilot AI review requested due to automatic review settings July 26, 2026 11:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mod_rewrite “reject list” documentation example to use an explicit <RequireAll> container so the configuration is syntactically valid while preserving the intended access control behavior (generally allow requests, but deny specific IPs).

Changes:

  • Wrap the mixed Require all granted + Require not ip ... directives in <RequireAll> within the <Location "/" > example.
  • Remove a trailing blank line at the end of the XML file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants