Clarify CGIVar REQUEST_URI query handling#695
Open
deprrous wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the documentation for CGIVar REQUEST_URI to match the current ap_add_cgi_vars() behavior: original-uri may include the query string, while current-uri keeps the query string in QUERY_STRING.
Changes:
- Update the English manual note to distinguish
original-urivscurrent-uriquery-string handling. - Apply the same clarification to the French translation (
core.xml.fr).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/manual/mod/core.xml | Clarifies REQUEST_URI / QUERY_STRING behavior per mode (original-uri vs current-uri). |
| docs/manual/mod/core.xml.fr | Mirrors the clarification in French; includes the same behavioral distinction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+788
to
+790
| Avec <code>current-uri</code>, <code>REQUEST_URI</code> est définie à partir | ||
| de l’URI actuellement traitée, et la chaîne de paramètres reste disponible | ||
| séparément dans <code>QUERY_STRING</code>. Cela est différent pour la |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a small docs regression from
73565fac0a.Before that change, the note matched what
ap_add_cgi_vars()still does today: the defaultoriginal-urimode can include the query string, whilecurrent-uriusesr->uriand leaves the query string inQUERY_STRING.This patch narrows the note back to that behavior and mirrors the same correction in
core.xml.fr.Checks:
git diff --checkxmllint --noout docs/manual/mod/core.xml(same pre-existing entity warnings elsewhere in the file)xmllint --noout docs/manual/mod/core.xml.fr(same pre-existing entity warnings elsewhere in the file)