Conversation
* modules/filters/mod_sed.c (sed_filter_ctxt): Add passed, evalerr. (keep_metadata): New. (append_bucket, sed_response_filter): Track whether anything has reached the next filter. (sed_response_filter): On a failed evaluation, pass the metadata on and go on doing so for the rest of the response, unless nothing has been written yet; carry metadata buckets other than EOS and FLUSH through rather than deleting them; don't take the first bucket of an empty brigade. * changes-entries/sed-eos-on-error.txt: Add. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NULL when filling eval->abuf, which otherwise runs one past the end of the array and over eval->aptr itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
case writes off the unsigned byte value, not off a sign-extended char. * changes-entries/sed-l-command.txt: Add. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
attribute, and don't pass a runtime string as the format. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
a capture which matched nothing as matching once; both loops step the input pointer by the capture length and so never terminate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
so drop .htaccess from their context list. [skip ci] Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
HttpdTestSetup.add_cgi_module): New, so a suite can ask for CGI without naming mod_cgid. (HttpdTestSetup._make_modules_conf): Use _cgi_module() for a requested "cgid" on every platform, not just Windows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* test/modules/filters/env.py (FiltersTestSetup.__init__): Load a CGI module. * test/modules/filters/htdocs/test1/cgi/echo.py, test/modules/filters/htdocs/test1/cgi/nobody.py: New. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
notroj
force-pushed
the
mod-sed-fixes
branch
from
September 23, 2026 19:58
222e56f to
020f430
Compare
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 24, 2026
* modules/filters/mod_sed.c (sed_filter_ctxt): Add passed, evalerr. (keep_metadata): New. (append_bucket, sed_response_filter): Track whether anything has reached the next filter. (sed_response_filter): On a failed evaluation, pass the metadata on and go on doing so for the rest of the response, unless nothing has been written yet; carry metadata buckets other than EOS and FLUSH through rather than deleting them; don't take the first bucket of an empty brigade. * changes-entries/sed-eos-on-error.txt: Add. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #769 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938485 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 24, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #769 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938486 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 24, 2026
case writes off the unsigned byte value, not off a sign-extended char. * changes-entries/sed-l-command.txt: Add. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #769 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938487 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 24, 2026
attribute, and don't pass a runtime string as the format. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #769 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938488 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 24, 2026
a capture which matched nothing as matching once; both loops step the input pointer by the capture length and so never terminate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #769 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938489 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 24, 2026
so drop .htaccess from their context list. [skip ci] Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #769 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938490 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 24, 2026
HttpdTestSetup.add_cgi_module): New, so a suite can ask for CGI without naming mod_cgid. (HttpdTestSetup._make_modules_conf): Use _cgi_module() for a requested "cgid" on every platform, not just Windows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #769 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938491 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commentary from Claude:
🤖 Generated with Claude Code