test(io): stop probing the EC2 metadata service in S3 tests - #897
Open
plusplusjiajia wants to merge 1 commit into
Open
test(io): stop probing the EC2 metadata service in S3 tests#897plusplusjiajia wants to merge 1 commit into
plusplusjiajia wants to merge 1 commit into
Conversation
plusplusjiajia
force-pushed
the
test-s3-disable-imds
branch
from
August 24, 2026 10:40
8427176 to
eadc269
Compare
wgtmac
approved these changes
Aug 24, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Seems reasonable for local run speedup. In the future, perhaps we can introduce a RAII approach to set and restore envs just like Arrow C++ does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Off EC2, every S3 client build in the test suite waits several seconds for the instance metadata probe to time out before falling back. No test in this binary wants those credentials, and the wait dominated the run:
file_io_testgoes from ~54s to 0.3s locally, in CI included.Set without overwriting, so a run that does want instance credentials can still export `AWS_EC2_METADATA_DISABLED=false