[local storage] Remove IPC lock file after releasing the lock#2172
Open
Sanjays2402 wants to merge 1 commit into
Open
[local storage] Remove IPC lock file after releasing the lock#2172Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
fasteners.InterProcessLock creates its lock file but never removes it, and LockLocalStorage did not remove it either. Because the file name is derived from a sha256 of the locked path, one file was left behind in the temporary directory for every distinct path ever locked, which can exhaust inodes on long running processes that write many objects. The lock file is now removed after the IPC lock is released. Closes apache#1975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1975
Description
fasteners.InterProcessLockcreates its lock file but never removes it, andLockLocalStorage.__exit__did not remove it either. The file name is a sha256of the locked path, so one file was left behind in the temp directory for every
distinct path ever locked -- a long running process writing many objects can
exhaust inodes. The lock file is now removed after the IPC lock is released.
Status
done, ready for review
Checklist (tick everything that applies)