Skip to content

Issue #513: Use IOException for invalid ZIP entries - #533

Open
jayalakshmi-sasidharan wants to merge 1 commit into
apache:masterfrom
jayalakshmi-sasidharan:fix-513-cacheutils-exception
Open

Issue #513: Use IOException for invalid ZIP entries#533
jayalakshmi-sasidharan wants to merge 1 commit into
apache:masterfrom
jayalakshmi-sasidharan:fix-513-cacheutils-exception

Conversation

@jayalakshmi-sasidharan

Copy link
Copy Markdown

Fixes #513.

CacheUtils.unzip() already declares IOException, but an invalid ZIP entry resolving outside the extraction directory was reported using an unchecked RuntimeException.

This change replaces that exception with IOException, keeping the failure consistent with the existing unzip() API contract.

A regression test was added using a ../outside.txt ZIP entry. The test verifies that:

  • IOException is thrown for the invalid entry
  • no file is written outside the extraction directory

The regression test fails against the previous implementation because it receives RuntimeException instead of IOException.

Validation:

mvn -Dtest=CacheUtilsTest test
mvn test
mvn verify
mvn verify -Prun-its-smoke
mvn verify -Prun-its

All tests pass.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CahcheUtils throws raw runtime exception

1 participant