Skip to content

[#391] Use System.lineSeparator() instead of System.getProperty(\"lin… - #407

Open
Neil-Tomar wants to merge 1 commit into
apache:masterfrom
Neil-Tomar:fix/391-use-line-separator
Open

[#391] Use System.lineSeparator() instead of System.getProperty(\"lin…#407
Neil-Tomar wants to merge 1 commit into
apache:masterfrom
Neil-Tomar:fix/391-use-line-separator

Conversation

@Neil-Tomar

Copy link
Copy Markdown

…e.separator")

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Neil-Tomar

Copy link
Copy Markdown
Author

Fixes #391

Replaces System.getProperty("line.separator") with System.lineSeparator(),
which cannot return null and has been available since Java 7.

  • AbstractHelpMojo.LS
  • DescribeMojoTest (which previously mixed both forms)
  • Updates the src/it verify.groovy scripts that used the old form
    (per discussion on the issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants