docs: correct three stale entries in the SQL option reference - #639
Open
jackylee-ch wants to merge 1 commit into
Open
docs: correct three stale entries in the SQL option reference#639jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
`docs/src/sql.md` documented `'cross-partition-update.enabled'`, which does not exist anywhere in the codebase — cross-partition update mode is inferred in `TableWrite` from `bucket = -1` plus a primary key that does not contain every partition field, never configured. Setting the documented option does nothing. The `changelog-producer = 'input'` row still said primary-key tables reject writes. That has been supported since the PK input-changelog write path landed; `test_pk_input_changelog_write_read` creates a PK table with that option and inserts into it successfully. The type mapping table listed `CHAR` under VarCharType and `BINARY` under VarBinaryType, but `sql_data_type_to_paimon_type` maps `CHAR(n)` to `CharType` and `BINARY(n)` to `BinaryType`, each defaulting to length 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three entries in
docs/src/sql.mdno longer match the code:'cross-partition-update.enabled'does not exist.grepfinds it only inthis doc. Cross-partition update mode is inferred in
TableWritefrombucket = -1plus a primary key that does not contain every partition field —it is never configured, so setting the documented option does nothing. Java has
no such key either.
changelog-producer = 'input'no longer rejects PK writes.test_pk_input_changelog_write_readcreates a primary-key table with thatoption and inserts into it successfully.
CHARandBINARYmap to their own types. The table listed them underVarCharType / VarBinaryType, but
sql_data_type_to_paimon_typemapsCHAR(n)to
CharTypeandBINARY(n)toBinaryType, each defaulting to length 1.