Skip to content

docs: correct three wrong default values in CoreOptions doc comments #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackylee-ch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: correct three wrong default values in CoreOptions doc comments #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/paimon/src/spec/core_options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ impl<'a> CoreOptions<'a> {
.unwrap_or(DEFAULT_MANIFEST_MERGE_MIN_COUNT)
}

/// Number of buckets for the table. Default is 1.
/// Number of buckets for the table. Default is -1 (dynamic bucket).
pub fn bucket(&self) -> i32 {
self.options
.get(BUCKET_OPTION)
Expand All @@ -896,7 +896,11 @@ impl<'a> CoreOptions<'a> {
}
}

/// Target file size for data files. Default is 128MB.
/// Target file size for data files. Default is 256MB.
///
/// Java leaves `target-file-size` without a default and documents 128 MB for
/// primary-key tables and 256 MB for append tables; this returns the append
/// value for both.
pub fn target_file_size(&self) -> i64 {
self.options
.get("target-file-size")
Expand Down Expand Up @@ -1086,7 +1090,7 @@ impl<'a> CoreOptions<'a> {

/// Target row number per bucket for dynamic bucket mode (bucket=-1).
/// When a bucket reaches this number, a new bucket is created.
/// Default is 200,000 (matching Java Paimon).
/// Default is 200,000. Java Paimon defaults this to 2,000,000.
pub fn dynamic_bucket_target_row_num(&self) -> i64 {
self.options
.get(DYNAMIC_BUCKET_TARGET_ROW_NUM_OPTION)
Expand Down
Loading