[python][ray] Incrementally commit update_by_row_id file groups - #8826
[python][ray] Incrementally commit update_by_row_id file groups#8826XiaoHongbo-Hope wants to merge 12 commits into
Conversation
9e0ef29 to
8612798
Compare
Zouxxyy
left a comment
There was a problem hiding this comment.
Two findings from this review:
JingsongLi
left a comment
There was a problem hiding this comment.
Just looking at the changes alone, it's too complicated; we need a simpler, more straightforward approach.
436c400 to
7615310
Compare
Got your point, just left core change now. |
ed04263 to
5d0b467
Compare
5d0b467 to
883da03
Compare
leaves12138
left a comment
There was a problem hiding this comment.
I found one blocking cleanup issue. The focused Ray update/merge/read test suites pass, but an incremental driver-side commit failure can abandon already-materialized group outputs.
If this is indeed the case, as stated in your documentation, then the implications are significant—far beyond what a simple description like “max_groups_per_commit” can capture. This is a major semantic change that has been overlooked. |
Updated, can you help check whether this looks good. |
Purpose
For large
update_by_row_idjobs, a single final commit makes late failures expensive because all uncommitted file groups must be rewritten.Add optional
max_groups_per_commitwindows while keeping the default single atomic commit. In incremental mode, ordinary group exceptions are returned as results so successful groups can be committed before the error is raised. Worker loss and other task-level failures which bypass Python exception handling may still lose results buffered by that task.Tests