[spark] Cache blob field lookup in SparkInternalRow - #8943
Open
zhuxiangyi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR optimizes
SparkInternalRow.create(rowType)for very wide nestedRowTypes.When Spark reads a Paimon table containing a wide struct, for example a struct with tens of thousands of fields, nested struct conversion can repeatedly create
SparkInternalRowwrappers. Before this change, each creation scanned all fields in theRowTypeto find BLOB fields.In production, executor threads can spend a significant amount of time in the following stack:
This repeated scan is expensive for very wide structs.
Brief change log
SparkInternalRow.IdentityHashMap[RowType, Set[Int]]so cache lookup does not callRowType.hashCodeorRowType.equals, which may also traverse wide schemas.SparkInternalRow.create(rowType)calls for the sameRowTypescan the fields only once.Verifying this change
This change added tests and can be verified as follows:
mvn -pl paimon-spark/paimon-spark-ut -am -Pfast-build -Pspark3 \ -DfailIfNoTests=false \ -DwildcardSuites=org.apache.paimon.spark.data.SparkInternalRowTest \ -Dtest=none testResult: