[full-text] Fix native reader cleanup on failures - #8950
Merged
Conversation
Preserve the primary failure when cleanup also fails, and always attempt to close both the native reader and its input stream. Add focused lifecycle tests for unchecked and native linkage failures. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
NativeFullTextGlobalIndexReadercould mask the original initialization failure when input cleanup also failed. Its close path also stopped after the native reader failed to close, leaving the input stream open.Preserve the primary failure, attach cleanup failures as suppressed exceptions, and always attempt to close both resources. Add focused lifecycle regression tests.
Tests
mvn -B -ntp verify -pl paimon-full-text -Dcheckstyle.skip=true -Dspotless.check.skip=true