GH-3708: Inline parquet.thrift - #3709
Open
divjotarora wants to merge 1 commit into
Open
Conversation
divjotarora
force-pushed
the
inline-thrift
branch
from
August 5, 2026 19:49
a165e84 to
12d885d
Compare
divjotarora
force-pushed
the
inline-thrift
branch
from
August 5, 2026 20:27
12d885d to
dc2c7b9
Compare
divjotarora
marked this pull request as ready for review
August 5, 2026 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It is currently not possible to build working POCs for unreleased parquet-format changes in parquet-java because the parquet-format dependency must be updated using a released version. This blocks reference implementations from merging and will become a bigger issue if the current versioning proposal goes through and we start having more "preview" features where writes are expected to support unreleased spec changes behind feature flags.
What changes are included in this PR?
This PR removes the dependency on github.com/apache/parquet-format and instead adds an inlined copy of
parquet.thrift(parquet-format-structures/src/main/thrift/parquet.thrift) as well as a "sidecar" metadata file (parquet-format-structures/src/main/thrift/parquet-format.version) to indicate the parquet-format version that's being inlined. This can be either an X.Y.Z semantic version or a commit hash.There are two scripts added to help manage the vendored copy:
dev/update-parquet-thrift.sh [$SHA | --version X.Y.Zupdates the inlinedparquet.thriftto match an upstream copy of parquet-format given either a commit hash (for POC development) or a version (for releases)dev/check-parquet-thrift-release.shchecks that inlinedparquet.thriftmirrors a parquet-format release, not an unreleased commit. This is meant to be used in parquet-java releases only, not to block features from merging.Are these changes tested?
Edit inlined parquet.thrift with a meaningless change and then validate it gets overwritten:
Also test updating to a commit rather than a version:
Are there any user-facing changes?
No
Closes #3708