Fix pdfbox 5079 - #530
Closed
valerybokov wants to merge 3 commits into
Closed
Fix pdfbox 5079#530valerybokov wants to merge 3 commits into
valerybokov wants to merge 3 commits into
Conversation
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 12, 2026
… by Valery Bokov; closes #530 git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/2.0@1938153 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 12, 2026
… by Valery Bokov; closes #530 git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/3.0@1938154 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDCalRGB.toRGB() only performed real CIE calibration for whitepoint (1 1 1) and otherwise fell back to a hack that returns the raw component values as-is. That hack was only ever validated for whitepoint D65 (0.9505 1.0 1.089), a workaround for producers that embed already-final RGB values (PDFBOX-2553), but it was being applied to every other whitepoint too, including this issue's D50 Wide Gamut RGB test image, whose intended red rendered as orange since its calibration was silently skipped.
Narrow the hack to trigger only for the exact D65 whitepoint it was written for; every other whitepoint, including (1 1 1) as before, now goes through the real calibration path.
Per https://www.apache.org/legal/generative-tooling.html: portions of this PR were produced with assistance from Claude Code (Anthropic), based on a bug was described in Apache PDFBOX Issue Tracker.
I've reviewed the generated code and confirm to the best of my knowledge that the output does not include any third-party copyrighted material and is compatible with the Apache License 2.0.