forwarder: close backend channel immediately if frontend closes - #2260
Merged
Conversation
When a peer closes their connection while we're establishing the backend connection, we must close the backend channel to release its file descriptors immediately. Previously, the code closed the peer channel (already closed anyway), leaving the backend channel orphaned until garbage collection. Now we explicitly close the backend channel when the peer channel is no longer active, preventing delayed FD cleanup. Fixes: apple#2261 Signed-off-by: Eric Ernst <eric_ernst@apple.com>
egernst
force-pushed
the
topic/forwarder-cleanup
branch
from
September 11, 2026 15:53
8dfe10f to
56b95bc
Compare
Code Coverage
|
dkovba
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a peer closes their connection while we're establishing the backend connection, we must close the backend channel to release its file descriptors immediately. Previously, the code closed the peer channel (already closed anyway), leaving the backend channel orphaned until garbage collection.
Now we explicitly close the backend channel when the peer channel is no longer active, preventing delayed FD cleanup.
Fixes: #2261
Important
All commits must be signed and verified. Pull requests containing unsigned or unverified commits cannot be built or merged. See the GitHub documentation for instructions.
For all but trivial fixes, make sure to first create a GitHub issue that concisely describes the bug or desired enhancement as justification for the change. Large PRs with no justifying issue will be closed.
Type of Change
Motivation and Context
[Why is this change needed?]
Testing