Skip to content

Update to Selenium 4.48.0 +semver:feature - #166

Merged
mialeska merged 2 commits into
masterfrom
enhancement/update-to-selenium-4.48.0
Sep 11, 2026
Merged

mialeska merged 2 commits into
masterfrom
enhancement/update-to-selenium-4.48.0

Conversation

@mialeska

Copy link
Copy Markdown
Contributor

Update dependency versions.
Change slf4j test dependency to nop to reduce spamming in test logs
Update DevTools references to v152 (use 151 in custom version tests)

Update dependency versions.
Change slf4j test dependency to nop to reduce spamming in test logs
Update DevTools references to v152 (use 151 in custom version tests)
@mialeska mialeska self-assigned this Sep 11, 2026
@mialeska mialeska added enhancement New feature or request dependencies Pull requests that update a dependency file java labels Sep 11, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Aquality Selenium Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: c17558cb-ba41-4c13-b54e-ee84713779a3

📥 Commits

Reviewing files that changed from the base of the PR and between 0cf7bbf and 766fee7.

📒 Files selected for processing (1)
  • src/main/java/aquality/selenium/browser/devtools/NetworkHandling.java

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: fe886718-9846-4b5a-9295-09e217279d85

📥 Commits

Reviewing files that changed from the base of the PR and between 557236d and 0cf7bbf.

📒 Files selected for processing (8)
  • pom.xml
  • src/main/java/aquality/selenium/browser/devtools/DevToolsHandling.java
  • src/main/java/aquality/selenium/browser/devtools/EmulationHandling.java
  • src/main/java/aquality/selenium/browser/devtools/JavaScriptHandling.java
  • src/main/java/aquality/selenium/browser/devtools/NetworkHandling.java
  • src/test/java/tests/usecases/devtools/DeviceEmulationTest.java
  • src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java
  • src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change updates Selenium DevTools imports from older protocol packages to newer versions. It also updates the Selenium core dependency and replaces the test-scoped SLF4J binding.

Changes

DevTools and dependency version alignment

Layer / File(s) Summary
Maven dependency updates
pom.xml
The Selenium core dependency changes to 4.18.0. The test SLF4J dependency changes to slf4j-nop version 2.0.19.
DevTools import updates
src/main/java/aquality/selenium/browser/devtools/*, src/test/java/tests/usecases/devtools/*
Production and test imports update to the corresponding Selenium DevTools protocol versions. The network Javadoc reference also uses v152.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 0cf7b

The PR updates the intended dependencies and DevTools references without introducing a known production or test risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the project to Selenium 4.48.0. It is concise and related to the dependency and DevTools updates.
Description check ✅ Passed The description accurately covers the dependency updates, the SLF4J test dependency change, and the DevTools v152 updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 7…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch enhancement/update-to-selenium-4.48.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checked the protocol trail
New DevTools versions now prevail
Imports hop in line
Dependencies shine
And quiet test logs tell the tale

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@mialeska
mialeska merged commit 04d424a into master Sep 11, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Aquality Selenium Sep 11, 2026
@mialeska
mialeska deleted the enhancement/update-to-selenium-4.48.0 branch September 11, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request java

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant