feat: log the text that was posted - #366
Merged
Merged
Conversation
通知の文面が意図どおりか (誰が主語か、リンクが崩れていないか) を確かめる 手段が無かった。`POST ok` は channel と本文の有無しか出しておらず、実際に 送った `text` はどこにも残らない。結果、文面を確認するにはテストに println を 仕込んで覗くことになっていた。 送った `text` を info で出す。 本文 (attachment) は出さない。長い上に、Issue の中身がログに残り続ける。 有無は既に `body` で出している。 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused change has no unresolved blocking issues.
Pull request overview
Logs the posted Slack message text after successful delivery without logging attachment contents.
Changes:
- Adds
textto thePOST okinfo log. - Preserves attachment body presence-only logging.
File summaries
| File | Summary |
|---|---|
src/slack.rs |
Includes posted text in successful-post logs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
通知の文面が意図どおりか (誰が主語か、リンクが崩れていないか) を後から確かめる手段が無かった。
POST okは channel と本文の有無しか出しておらず、実際に送ったtextはどこにも残らない。結果、文面を確認するにはテストにprintln!を仕込んで覗くことになっていた。送った
textを info で出す。本文 (attachment) は出さない。長い上に、Issue の中身がログに残り続ける。有無は既に
bodyで出している。🤖 Generated with Claude Code