Pie chart: surplus slivers close smoothly instead of leaving a white gap - #630
Open
skaphan wants to merge 1 commit into
Open
Pie chart: surplus slivers close smoothly instead of leaving a white gap#630skaphan wants to merge 1 commit into
skaphan wants to merge 1 commit into
Conversation
When an elected candidate's surplus transfers, the hatched sliver was deleted at full size at the start of the consolidate phase — a white gap in the pie that neighboring slices then closed over. The closing data now carries the transfer sub-slice as a zero-value entry, so the same angular tween that closes eliminated candidates' slices closes the sliver too. Bundle built from rcv-pie-chart acb3dd7 (source fix in PieChartGraphics.svelte updatePie). Co-Authored-By: Claude Fable 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an elected candidate's surplus transfers, the grayed-out sliver of their slice was removed at full size at the start of the consolidate phase, leaving a white gap that neighboring slices then closed over. This updates the pie bundle so the sliver shrinks closed with the same animation eliminated candidates get.
Source fix is in the pie component's
updatePie: the closing transition's data now retains the transfer sub-slice as a zero-value entry, so the keyed data join tweens it shut instead of exit-removing it at full size.Verified on the 2013 Minneapolis Park Board election (three surplus rounds): previously every sliver popped to a white gap; now each sweeps closed, hatched, through the normal transition.
🤖 Generated with Claude Code