Skip to content

tests: Add coverage for ARI in-dialog channel MESSAGE. - #152

Open
owoschhodan wants to merge 1 commit into
asterisk:masterfrom
owoschhodan:master-issue-1810
Open

tests: Add coverage for ARI in-dialog channel MESSAGE.#152
owoschhodan wants to merge 1 commit into
asterisk:masterfrom
owoschhodan:master-issue-1810

Conversation

@owoschhodan

Copy link
Copy Markdown

Add testsuite coverage for the new ARI channels/{channelId}/sendMessage
endpoint and the ChannelMessageReceived/ChannelMessageDeliveryStatus events
introduced in asterisk/asterisk#1810.

  • rest_api/channels/send_message: exercises sendMessage success paths (plain
    text, JSON body, sequential and concurrent requests), error responses
    (404 dead channel, 409 not in Stasis, 412 invalid state, 501 unsupported
    channel type), authentication/proxy-authentication challenges, and
    delivery-status correlation via request_id.
  • rest_api/channels/recv_in_dialog_message: verifies an incoming in-dialog
    SIP MESSAGE is published to the owning channel's Stasis application as
    ChannelMessageReceived.
  • channels/pjsip/message/message_sendtext_no_messaging_module: verifies
    chan_pjsip's sendtext() behavior when res_pjsip_messaging is not loaded.

Add testsuite coverage for the new ARI channels/{channelId}/sendMessage
endpoint and the ChannelMessageReceived/ChannelMessageDeliveryStatus events
introduced in asterisk/asterisk#1810.

- rest_api/channels/send_message: exercises sendMessage success paths (plain
  text, JSON body, sequential and concurrent requests), error responses
  (404 dead channel, 409 not in Stasis, 412 invalid state, 501 unsupported
  channel type), authentication/proxy-authentication challenges, and
  delivery-status correlation via request_id.
- rest_api/channels/recv_in_dialog_message: verifies an incoming in-dialog
  SIP MESSAGE is published to the owning channel's Stasis application as
  ChannelMessageReceived.
- channels/pjsip/message/message_sendtext_no_messaging_module: verifies
  chan_pjsip's sendtext() behavior when res_pjsip_messaging is not loaded.
@sangoma-oss-cla

sangoma-oss-cla Bot commented Aug 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@owoschhodan

Copy link
Copy Markdown
Author

Disclosure: the new tests in this PR (send_message/, recv_in_dialog_message,
message_sendtext_no_messaging_module) were generated with AI assistance
(Claude Code), then human-reviewed, adapted, and verified by running them
against a real build (see the linked asterisk PR for the full test-run
results).

@owoschhodan

owoschhodan commented Aug 24, 2026

Copy link
Copy Markdown
Author

cherry-pick-to: 20
cherry-pick-to: 22
cherry-pick-to: 24

@owoschhodan

Copy link
Copy Markdown
Author

asterisk-test-pr: 2118

@github-actions

Copy link
Copy Markdown

Workflow Check failed
master-gates-check-98: FAILED TEST: rest_api/channels/recv_in_dialog_message
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/auth_challenge_no_credentials
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/auth_challenge_success
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/duplicate_request_id
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/final_sip_failure
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/five_sequential_requests_success
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/invalid_state_412
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/json_example_success
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/load_message_send
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/longer_message_array_success
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/non_pjsip_channel_501
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/not_in_stasis_409
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/overlap_pending_request
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/plain_text_success
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/proxy_auth_challenge_no_credentials
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/proxy_auth_challenge_success
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/sequential_requests_success
master-gates-check-98: FAILED TEST: rest_api/channels/send_message/snoop_channel_501

@owoschhodan

Copy link
Copy Markdown
Author

The Gate test run above failed because it built against upstream master instead of asterisk#2118.
The pr comment linking the two PRs was posted about 7 minutes after CI started,
past the 2 minute window mentioned in the Code Contribution guide.

The link is now in place.
Could someone on the team please recheck this PR so CI picks it up against the linked branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant