Unify browser storage quota handling - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
navigator.storage.estimate()gates from bundled offline games and Internet Games installs.Why
Brave deliberately generalizes
StorageManager.estimate()and browser estimates are not exact capacity guarantees. Treating them as preflight authorization caused valid downloads to be rejected before the browser attempted a real write.Impact
Downloads now proceed until the underlying Cache Storage, IndexedDB, or OPFS operation actually refuses the write. Real
QuotaExceededErrorfailures are reported consistently, and partial data is cleaned up. Storage estimates remain available for informational UI only.Validation
bun run test— 119 passing, 998 assertionsbun run qualitybun run build --revision HEAD