fix: preferences changed utc - #85
Merged
august-alt merged 3 commits intoAug 24, 2026
Merged
Conversation
august-alt
reviewed
Aug 24, 2026
august-alt
left a comment
august-alt
left a comment
Owner
There was a problem hiding this comment.
I'm currently building and testing the application with this patch. I suggest you do the same, check that you can build and run current version of GPUI. And also check that patch fixes the issue we were observing earlier.
Contributor
Author
|
Fixed. Sorry, I accidentally used the clang-format on this file last time. |
august-alt
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the GPO change timestamp: GPUI previously stored local time in the changed attribute, although MS-GPPREF requires UTC in the
YYYY-MM-DD HH:MM:SSformat. As a result, gpresult displayed a timestamp N hours ahead in UTC+N. The timestamp is now generated using QDateTime::currentDateTimeUtc(). Regression tests were added, and the existing test was moved to a separate directory with only its relative paths adjusted.